Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize(hz): handler_single.go supports more template parameters #1004

Merged
merged 4 commits into from
Dec 1, 2023
Merged

optimize(hz): handler_single.go supports more template parameters #1004

merged 4 commits into from
Dec 1, 2023

Conversation

ypo2478
Copy link
Contributor

@ypo2478 ypo2478 commented Nov 18, 2023 •
edited by FGYFFFF
Loading

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: handler_single.go supports more template parameters
zh(optional):

(Optional) Which issue(s) this PR fixes:

#1001

(Optional) The PR that updates user documentation:

@ypo2478 ypo2478 requested review from a team as code owners November 18, 2023 06:28
@li-jin-gou li-jin-gou linked an issue Nov 19, 2023 that may be closed by this pull request
[QUESTION] hz handler.go 与 handler_single.go传值不一样 #1001
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85d1aff) 82.57% compared to head (21b9a61) 82.59%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1004      +/-   ##
===========================================
+ Coverage    82.57%   82.59%   +0.02%     
===========================================
  Files           98       98              
  Lines         9974     9974              
===========================================
+ Hits          8236     8238       +2     
+ Misses        1242     1241       -1     
+ Partials       496      495       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@FGYFFFF FGYFFFF changed the title optimize(hz): handler_single.go supports the same methods as handler.go optimize(hz): handler_single.go supports more template parameters Dec 1, 2023
FGYFFFF
FGYFFFF approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@FGYFFFF FGYFFFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@li-jin-gou li-jin-gou merged commit 22aafdc into cloudwego:develop Dec 1, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jin-gou li-jin-gou li-jin-gou approved these changes

@FGYFFFF FGYFFFF FGYFFFF approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QUESTION] hz handler.go 与 handler_single.go传值不一样
4 participants
@ypo2478 @CLAassistant @FGYFFFF @li-jin-gou